On 2/6/18 12:27 PM, Omar Sandoval wrote: > On Wed, Jan 24, 2018 at 03:22:58PM -0800, Howard McLauchlan wrote: >> The classic error injection mechanism, should_fail_request() does not >> support use cases where more information is required (from the entire >> struct bio, for example). >> >> To that end, this patch introduces should_fail_bio(), which calls >> should_fail_request() under the hood but provides a convenient >> place for kprobes to hook into if they require the entire struct bio. >> This patch also replaces some existing calls to should_fail_request() >> with should_fail_bio() with no degradation in performance. > > Reviewed-by: Omar Sandoval <osandov@xxxxxx> > > Jens, can we pick this up for 4.16? The necessary BPF support has been > merged into Linus' tree. I don't see why not - but the patch no longer applies. Howard, can you respin it? -- Jens Axboe