RE: [PATCH V2 8/8] scsi: hpsa: use blk_mq to solve irq affinity issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Laurence Oberman [mailto:loberman@xxxxxxxxxx]
> Sent: Monday, February 05, 2018 9:58 AM
> To: Ming Lei <ming.lei@xxxxxxxxxx>; Jens Axboe <axboe@xxxxxxxxx>; linux-
> block@xxxxxxxxxxxxxxx; Christoph Hellwig <hch@xxxxxxxxxxxxx>; Mike Snitzer
> <snitzer@xxxxxxxxxx>; Don Brace <don.brace@xxxxxxxxxxxxx>
> Cc: linux-scsi@xxxxxxxxxxxxxxx; Hannes Reinecke <hare@xxxxxxx>; Arun Easi
> <arun.easi@xxxxxxxxxx>; Omar Sandoval <osandov@xxxxxx>; Martin K .
> Petersen <martin.petersen@xxxxxxxxxx>; James Bottomley
> <james.bottomley@xxxxxxxxxxxxxxxxxxxxx>; Christoph Hellwig <hch@xxxxxx>;
> Don Brace <don.brace@xxxxxxxxxxxxx>; Kashyap Desai
> <kashyap.desai@xxxxxxxxxxxx>; Peter Rivera <peter.rivera@xxxxxxxxxxxx>;
> Paolo Bonzini <pbonzini@xxxxxxxxxx>
> Subject: Re: [PATCH V2 8/8] scsi: hpsa: use blk_mq to solve irq affinity issue
> 
> EXTERNAL EMAIL
> 
> 
> On Mon, 2018-02-05 at 23:20 +0800, Ming Lei wrote:
> > This patch uses .force_blk_mq to drive HPSA via SCSI_MQ, meantime
> > maps
> > each reply queue to blk_mq's hw queue, then .queuecommand can always
> > choose the hw queue as the reply queue. And if no any online CPU is
> > mapped to one hw queue, request can't be submitted to this hw queue
> > at all, finally the irq affinity issue is solved.
> >
> > Cc: Hannes Reinecke <hare@xxxxxxx>
> > Cc: Arun Easi <arun.easi@xxxxxxxxxx>
> > Cc: Omar Sandoval <osandov@xxxxxx>,
> > Cc: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>,
> > Cc: James Bottomley <james.bottomley@xxxxxxxxxxxxxxxxxxxxx>,
> > Cc: Christoph Hellwig <hch@xxxxxx>,
> > Cc: Don Brace <don.brace@xxxxxxxxxxxxx>
> > Cc: Kashyap Desai <kashyap.desai@xxxxxxxxxxxx>
> > Cc: Peter Rivera <peter.rivera@xxxxxxxxxxxx>
> > Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> > Cc: Mike Snitzer <snitzer@xxxxxxxxxx>
> > Tested-by: Laurence Oberman <loberman@xxxxxxxxxx>
> > Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxx>
> > ---
> >  drivers/scsi/hpsa.c | 51 ++++++++++++++++++++++++++++++++++---------
> This is a critical issue on the HPSA because Linus already has the
> original commit that causes the system to fail to boot.
> 
> All my testing was on DL380 G7 servers with:
> 
> Hewlett-Packard Company Smart Array G6 controllers
> Vendor: HP       Model: P410i            Rev: 6.64
> 
> Ming's patch fixes this so we need to try move this along.
> 
> I have a DL380 G8 as well which is also likely exposed here and I added
>  Don Brace for FYI to this list.
> 
> Thanks Ming

Tested-by: Don Brace <don.brace@xxxxxxxxxxxxx>
P441, P431, P830i, H240

Acked-by: Don Brace <don.brace@xxxxxxxxxxxxx>







[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux