On Fri, Feb 2, 2018 at 4:55 PM, Bart Van Assche <Bart.VanAssche@xxxxxxx> wrote: > On Fri, 2018-02-02 at 15:09 +0100, Roman Pen wrote: >> +Entries under /sys/kernel/ibnbd_client/ >> +======================================= >> [ ... ] > > You will need Greg KH's permission to add new entries directly under /sys/kernel. > Since I think that it is unlikely that he will give that permission: have you > considered to add the new client entries under /sys/class/block for the client and > /sys/kernel/configfs/ibnbd for the target, similar to what the NVMeOF drivers do > today? /sys/kernel was chosen ages ago and I completely forgot to move it to configfs. IBTRS is not a block device, so for some read-only entries (statistics or states) something else should be probably used, not configfs. Or it is fine to read state of the connection from configfs? For me sounds a bit weird. -- Roman