On Tue, 2018-01-30 at 09:07 +0800, Ming Lei wrote: > On Mon, Jan 29, 2018 at 04:48:31PM +0000, Bart Van Assche wrote: > > - It is easy to fix this race inside the block layer, namely by using > > call_rcu() inside the blk_mq_delay_run_hw_queue() implementation to > > postpone the queue rerunning until after the request has been added back to > > the dispatch list. > > It is just easy to say, can you cook a patch and fix all drivers first? Please reread what I wrote. I proposed to change the blk_mq_delay_run_hw_queue() IMPLEMENTATION such that the callers do not have to be modified. > [ ... ] Later, you admitted you understood the patch wrong. [ ... ] That's nonsense. I never wrote that. Bart.