On Tue, Jan 23, 2018 at 08:30:41AM -0500, Martin K. Petersen wrote: > > Ming, > > > + * Block layer and block driver specific status, which is ususally returnd > ^^^^^^^ > > + * from driver to block layer in IO path. > > Given that the comment blurb is long and the flag not defined until > later, it is not entirely obvious that you are documenting > BLK_STS_DEV_RESOURCE. So please make that clear at the beginning of the > comment. > > > + * If driver isn't sure if the queue can be run again for dealing with the > > + * current request after this kind of resource is available, please return > > + * BLK_STS_SOURCE, for example, when memory allocation, DMA Mapping or other > ^^^^^^^^^^^^^^ This one is correct, just try to describe their difference. -- Ming
