On 1/15/18 8:52 AM, Mike Snitzer wrote: > On Mon, Jan 15 2018 at 10:33am -0500, > Jens Axboe <axboe@xxxxxxxxx> wrote: > >> On 1/14/18 7:59 PM, Mike Snitzer wrote: > ... >>> Ming Lei (3): >>> blk-mq: move actual issue into __blk_mq_issue_req helper >> >> I don't like this patch at all - it's a 10 line function (if that) >> that ends up with three outputs, two of them hidden in passed >> in pointers. On top of that, a function that is named >> __blk_mq_issue_req() and returns bool, you would logically expect >> a 'true' return to mean that it succeeded. This is the opposite. >> >> Not strongly opposed to the rest. > > OK, I'll have a closer look at how to clean it up (and also get with > Ming). > > In the meantime, you can either cherry-pick my first 4 patches or feel > free to use this to pull them in: I took 1-3 initially, added 4 now as well. -- Jens Axboe
