On Fri, 2018-01-12 at 14:55 -0700, Jens Axboe wrote:
> On 1/12/18 2:52 PM, Bart Van Assche wrote:
> > When debugging e.g. the SCSI timeout handler it is important that
> > requests that have not yet been started or that already have
> > completed are also reported through debugfs.
> >
> > This patch depends on a patch that went upstream recently, namely
> > commit 14e3062fb185 ("scsi: core: Fix a scsi_show_rq() NULL pointer
> > dereference").
>
> Why don't we just kill the check, and dump any request that has a
> matching hctx? We already know the bit was set, so just print
> all of them.
It is very helpful during debugging that requests owned by a block driver and
requests owned by the block layer core show up in different debugfs files.
Removing the check completely would cause all requests to show up in the same
debugfs file and would make interpreting the contents of these debugfs files
much harder.
Thanks,
Bart.
