Re: [PATCH 2/4] block: add accessors for setting/querying request deadline

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2018-01-09 at 11:27 -0700, Jens Axboe wrote:
> +static inline void blk_rq_set_deadline(struct request *rq, unsigned long time)
> +{
> +	rq->__deadline = time & ~0x1;
> +}
> +
> +static inline unsigned long blk_rq_deadline(struct request *rq)
> +{
> +	return rq->__deadline & ~0x1;
> +}

Hello Jens,

The type of rq->__deadline is "unsigned long" but the type of the right-hand
side constant is int. Shouldn't an "UL" suffix be added to the RHS constant?

Thanks,

Bart.




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux