On Tue, Jan 09, 2018 at 08:38:55AM -0700, Jens Axboe wrote: > On 1/9/18 8:29 AM, Jens Axboe wrote: > > On Tue, Jan 09 2018, Ming Lei wrote: > >> HW queues may be unmapped in some cases, such as blk_mq_update_nr_hw_queues(), > >> then we need to check it before calling blk_mq_tag_idle(), otherwise > >> the following kernel oops can be triggered, so fix it by checking if > >> the hw queue is unmapped since it doesn't make sense to idle the tags > >> any more after hw queues are unmapped. > > > > Seems cleaner to just move the mapped check to the idling function, > > especially since we already have the same check in the other spot where > > we call the idling. > > Ho hum, I guess that requires shuffling some code/includes to > actually do that. I'll just apply yours as-is. Yes, that need to move blk_mq_hw_queue_mapped() into blk-mq-tag.h since the two headers are included by each other, seem some cleanup are needed for headers. Thanks, Ming
