On Fri, Dec 29, 2017 at 10:48:14AM +0100, Christoph Hellwig wrote: > On Wed, Dec 27, 2017 at 11:01:48PM +0200, Sagi Grimberg wrote: > > > >> Awesome! > >> > >> Reviewed-by: Sagi Grimberg <sagi@xxxxxxxxxxx> > > > > Wait, aren't we unquiesce queues also in nvme_dev_disable? > > > > Doesn't that rely that the queues are suspended and queue_rq > > will fail there? > > We don't seem to have any other check as far as I can tell. Ok, we currently do need this check in the submission side to flush entered requests on invalidated hw contexts. We didn't have a way to back out entered requests before, so that's why this request killing check still exists. We can steal bio's to back out requests now, so I think we should do that instead of failing them. I'll do rework the series a bit to make that possible, plus add the removal of the submission side nvme_process_cq, and resend.
