On Wed, 2017-11-29 at 10:57 +0800, chenxiang (M) wrote: > I applied this v2 patchset to kernel 4.15-rc1, running fio on a SATA > disk, then disable the disk with sysfs interface > (echo 0 > /sys/class/sas_phy/phy-1:0:1/enable), and find system is hung. > But with v1 patch, it doesn't has this issue. Hello chenxiang, Would it be possible to repeat your test with v2 of this series and Martin's for-4.16 SCSI tree merged into your kernel test tree? Martin's tree is available at https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/log/?h=4.16/scsi-queue. The following patch in that tree fixes a race condition that sometimes caused the SCSI error handler not to be woken up: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=4.16/scsi-queue&id=3bd6f43f5cb3714f70c591514f344389df593501 Thanks, Bart.