On 12/12/2017 6:06 AM, Linus Torvalds wrote:
On Sun, Dec 10, 2017 at 7:50 PM, Theodore Ts'o <tytso@xxxxxxx> wrote:
CONFIG_LOCKDEP_CROSSRELEASE and CONFIG_LOCKDEP_COMPLETIONS can result
in a large number of false positives because lockdep doesn't
understand how to deal with multiple stacked loop or MD devices.
Guys, can we just remove this nasty crud already?
It's not working. Give it up. It was complex, it was buggy, it was slow.
Sorry to hear that, but it works well and fortunately it has not
been buggy until now, of course, it has been wrongly accused
twice though. Furthormore, it's not slow now since it was fixed.
You seem to say that w/o foundation but emotionally.
The *problem* is false positives, since locks and waiters in
kernel are not classified properly, at the moment, which is just
a fact that is not related to cross-release stuff at all. IOW,
that would be useful once all locks and waiters are classified
correctly. It might take time but the classifying is a must-do
we have to keep doing.
I admit to make it optional for now, but I don't see why you
want to remove it entierly.
Now it's causing people to disable lockdep entirely, or play these
kinds of games in unrelated trees.
It's time to give up on bad debugging, and definitely _not_ enable it
by default for PROVE_LOCKING.
Ted: in the meantime, don't use PROVE_LOCKING. Just use
DEBUG_LOCK_ALLOC instead. Please drop this patch from your tree.
Linus
--
Thanks,
Byungchul
