Re: [PATCH] blkcg: correctly update stat

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 14, 2017 at 10:05:07AM -0800, Shaohua Li wrote:
> blkcg_bio_issue_check() checks throtl for stat update, which isn't good
> because the bio could be splitted into small bios, the samll bios go
> into blkcg_bio_issue_check again and we update stat for the small bios,
> so we the stat is double charged. To fix this, we only update stat if
> the bio doesn't have BIO_THROTTLED flag. The fix will update stat ahead
> of bio skips from blk-throttle, but eventually the stat is correct.
> 
> This patch is on top of patch:
> https://marc.info/?l=linux-block&m=151060860608914&w=2
> 
> Cc: Tejun Heo <tj@xxxxxxxxxx>
> Signed-off-by: Shaohua Li <shli@xxxxxx>

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

Thanks.

-- 
tejun



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux