On 11/09/2017 06:44 PM, Christoph Hellwig wrote: > We do this by adding a helper that returns the ns_head for a device that > can belong to either the per-controller or per-subsystem block device > nodes, and otherwise reuse all the existing code. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > Reviewed-by: Keith Busch <keith.busch@xxxxxxxxx> > Reviewed-by: Sagi Grimberg <sagi@xxxxxxxxxxx> > Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx> > --- > drivers/nvme/host/core.c | 57 +++++++++++++++++++++++-------------------- > drivers/nvme/host/multipath.c | 6 +++++ > drivers/nvme/host/nvme.h | 1 + > 3 files changed, 38 insertions(+), 26 deletions(-) > In principle, yes, but I would like to have some more info (like subsysnqn, and maybe 'model' etc) in the subsys sysfs entry, too. But this can be handled in a later patch, so: Reviewed-by: Hannes Reinecke <hare@xxxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)