On Thu, Nov 9, 2017 at 8:12 AM, Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote: > On 08/11/17 11:24, Linus Walleij wrote: >> On Fri, Nov 3, 2017 at 2:20 PM, Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote: >> >>> Add CQHCI initialization and implement CQHCI operations for Intel GLK. >>> >>> Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx> >> >> This patch seems OK in context, but it merely illustrates the >> weirdness of .[runtime]_suspend/resume calling into CQE-specific >> APIs rather than using generic host callbacks. > > Your comment makes no sense at all. The host driver has > [runtime]_suspend/resume callbacks and it is up to the host driver to decide > what to do. CQHCI provides helpers since that is the whole point of having > a CQHCI library. Yeah I didn't see it in context, the CQHCI library for these hosts make a lot of sense. Yours, Linus Walleij
