Re: [PATCH] blk-mq: put driver tag if dispatch budget can't be got

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 07, 2017 at 09:23:19AM -0700, Jens Axboe wrote:
> On 11/07/2017 02:59 AM, Ming Lei wrote:
> > We have to put the driver tag if dispatch budget can't be got, otherwise
> > it might cause IO deadlock, especially in case that size of tags is very
> > small.
> 
> Fix looks correct to me, but it's missing a Fixes: line. I tried to
> go back a little bit, but it looks like this failure case was
> introduced just recently:
> 
> commit 88022d7201e96b43f1754b0358fc6bcd8dbdcde1
> Author: Ming Lei <ming.lei@xxxxxxxxxx>
> Date:   Sun Nov 5 02:21:12 2017 +0800
> 
>     blk-mq: don't handle failure in .get_budget

Actually it is introduced in de1482974080ec9ef41(blk-mq: introduce .get_budget and
.put_budget in blk_mq_ops), will add Fixes in V2.

Thanks,
Ming



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux