Re: [PATCH] blk-mq: quiesce queue during switching io sched and updating nr_requests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2017-11-06 at 18:43 +0800, Ming Lei wrote:
> @@ -2665,6 +2665,7 @@ int blk_mq_update_nr_requests(struct request_queue *q, unsigned int nr)
>  		return -EINVAL;
>  
>  	blk_mq_freeze_queue(q);
> +	blk_mq_quiesce_queue(q);
>  
>  	ret = 0;
>  	queue_for_each_hw_ctx(q, hctx, i) {

Before more blk_mq_quiesce_queue() callers are added a counter mechanism
has to be added into blk_mq_quiesce_queue_nowait() and blk_mq_unquiesce_queue()
to avoid trouble due to concurrent blk_mq_quiesce_queue_nowait() and/or
blk_mq_unquiesce_queue() calls.

Bart.




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux