On Thu, Nov 02, 2017 at 11:43:55PM +0000, Bart Van Assche wrote: > On Fri, 2017-11-03 at 07:38 +0800, Ming Lei wrote: > > On Thu, Nov 02, 2017 at 03:57:05PM +0000, Bart Van Assche wrote: > > > On Wed, 2017-11-01 at 08:21 -0600, Jens Axboe wrote: > > > > Fixed that up, and applied these two patches as well. > > > > > > Hello Jens, > > > > > > Recently I noticed that a test system sporadically hangs during boot (Dell > > > PowerEdge R720 that boots from a hard disk connected to a MegaRAID SAS adapter) > > > and also that srp-tests systematically hangs. Reverting the two patches from > > > this series fixes both issues. I'm not sure there is another solution than > > > reverting the two patches from this series. > > > > Then we need to find the root cause, instead of using sort of workaround > > as before. > > > > For SCSI, the restart is always run from scsi_end_request(), and this > > kind of restart from all hctx isn't necessary at all. > > Yes, we need to find the root cause, but after these two patches have either > been reverted or have been removed from the for-4.15 queue. Otherwise if a > bisect lands in the middle of these two patches and the fix for these patches > that would be very frustrating for the person who is running the bisect. Could you please share your srp-tests script? I may find a IB/SRP system to see if I can reproduce this issue and figure out one solution. -- Ming
