On Mon, Oct 30, 2017 at 11:37:55AM +0800, Guan Junxiong wrote: > > + head->disk->flags = GENHD_FL_EXT_DEVT; > > + sprintf(head->disk->disk_name, "nvme%dn%d", > > + ctrl->subsys->instance, nsid); > > Is it okay to use head->instance instead of nsid for disk name nvme#n# ? > Becuase _nsid_ sets are not continuous sometimes, so disk name is ugly in that case. This actually was supposed to be the ns_head instance, that's why the ns_ida moved to the subsystem. I've fixed it up.