On 10/30/2017 05:02 PM, Bart Van Assche wrote: > Instead of referring from inside drivers/cdrom/Makefile to all the > drivers that use this driver, let these drivers select the cdrom > driver. This change makes the cdrom build code follow the approach > that is used for most other drivers, namely refer from the higher > layers to the lower layer instead of from the lower layer to the > higher layers. > > Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxx> > Cc: Christoph Hellwig <hch@xxxxxx> > Cc: Hannes Reinecke <hare@xxxxxxx> > Cc: Johannes Thumshirn <jthumshirn@xxxxxxx> > --- > drivers/block/Kconfig | 12 ++++++++++++ > drivers/block/paride/Kconfig | 1 + > drivers/cdrom/Makefile | 15 ++------------- > drivers/ide/Kconfig | 1 + > drivers/scsi/Kconfig | 1 + > 5 files changed, 17 insertions(+), 13 deletions(-) > You seem to have too much spare time ... Reviewed-by: Hannes Reinecke <hare@xxxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)