On 10/24/2017 11:27 PM, Ilya Dryomov wrote: > On Mon, Oct 16, 2017 at 3:59 PM, Ilya Dryomov <idryomov@xxxxxxxxx> wrote: >> Hi Christoph, Martin, >> >> blkdev_issue_zeroout() now checks for any error. This required a minor >> refactor, so I dropped the stable tag, Jens can add it back if needed. >> >> v2 -> v3: >> - another code flow change in blkdev_issue_zeroout() suggested by >> Christoph -- no functional changes >> >> v1 -> v2: >> - changed code flow in blkdev_issue_zeroout() according to Christoph's >> suggestion >> - this required adding additional checks to blkdev_issue_zeroout() and >> __blkdev_issue_zero_pages(), the latter is no longer void >> >> Previous version at >> >> https://marc.info/?l=linux-block&m=150712940922089&w=2 >> >> Thanks, >> >> Ilya >> >> >> Ilya Dryomov (2): >> block: factor out __blkdev_issue_zero_pages() >> block: cope with WRITE ZEROES failing in blkdev_issue_zeroout() >> >> block/blk-lib.c | 108 +++++++++++++++++++++++++++++++++++++------------------- >> 1 file changed, 72 insertions(+), 36 deletions(-) > > Jens, can you pick these up? Technically this is a user-visible > regression (Fixes tag in 2/2), but we are late in the cycle so I'm not > sure what is the right thing to do here. It wasn't introduced in this cycle, so there's little point in trying to rush it for 4.14. I have applied it for 4.15, thanks. -- Jens Axboe
