On 10/23/2017 04:51 PM, Christoph Hellwig wrote: > This is a much more sensible check than just the admin queue. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > Reviewed-by: Sagi Grimberg <sagi@xxxxxxxxx> > Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx> > --- > drivers/nvme/host/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c > index a56a1e0432e7..df525ab42fcd 100644 > --- a/drivers/nvme/host/core.c > +++ b/drivers/nvme/host/core.c > @@ -1891,7 +1891,7 @@ static int nvme_dev_open(struct inode *inode, struct file *file) > struct nvme_ctrl *ctrl = > container_of(inode->i_cdev, struct nvme_ctrl, cdev); > > - if (!ctrl->admin_q) > + if (ctrl->state != NVME_CTRL_LIVE) > return -EWOULDBLOCK; > file->private_data = ctrl; > return 0; > Reviewed-by: Hannes Reinecke <hare@xxxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
