Re: [PATCH] bcache: writeback rate clamping: make 32 bit safe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2017/10/17 上午1:34, Michael Lyle wrote:
> Sorry this got through to linux-block, was detected by the kbuilds test
> robot.  NSEC_PER_SEC is a long constant; 2.5 * 10^9 doesn't fit in a
> signed long constant.
> 
> Signed-off-by: Michael Lyle <mlyle@xxxxxxxx>

I forgot i386 config... sorry too...

Reviewed-by: Coly Li <colyli@xxxxxxx>

Thanks to Michael for the fix.

Coly Li

> ---
>  drivers/md/bcache/util.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/md/bcache/util.c b/drivers/md/bcache/util.c
> index 4dbe37e82877..e548b8b51322 100644
> --- a/drivers/md/bcache/util.c
> +++ b/drivers/md/bcache/util.c
> @@ -238,8 +238,8 @@ uint64_t bch_next_delay(struct bch_ratelimit *d, uint64_t done)
>  	 * don't let us sleep more than 2.5 seconds (so we can notice/respond
>  	 * if the control system tells us to speed up!).
>  	 */
> -	if (time_before64(now + NSEC_PER_SEC * 5 / 2, d->next))
> -		d->next = now + NSEC_PER_SEC * 5 / 2;
> +	if (time_before64(now + NSEC_PER_SEC * 5LLU / 2LLU, d->next))
> +		d->next = now + NSEC_PER_SEC * 5LLU / 2LLU;
>  
>  	if (time_after64(now - NSEC_PER_SEC * 2, d->next))
>  		d->next = now - NSEC_PER_SEC * 2;




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux