> On 6 Oct 2017, at 14.08, Javier González <jg@xxxxxxxxxxx> wrote: > >> On 6 Oct 2017, at 14.06, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: >> >> On Fri, Oct 06, 2017 at 02:01:46PM +0200, Javier González wrote: >>> I think it is good to fail fast as any other nvme I/O command and then >>> recover in pblk if necessary. >> >> Note that we only do it for other nvme _passthrough_ commands - the >> actual I/O commands dot not get the failfast flag. > > Yes. I was thinking of the LightNVM-specific _passthrough_ used by > liblightnvm since I'm refactoring the sync. path at the moment; the > "normal" async. path will be untouched for now. In fact, for the normal I/O path the whole idea is to do this directly in pblk, when we use struct request, and drop all these conversions in lightnvm.c. But that will be later on... Javier
Attachment:
signature.asc
Description: Message signed with OpenPGP
