On Wed, 2017-10-04 at 15:53 +0800, Ming Lei wrote: > I have commented on Bart's patchset before, but my comments > never gets addressed: > > 1) no MD changes required on this issue I did not address that comment because you have another view on how suspend and resume should work than the rest of the kernel community. See also the detailed explanation in https://marc.info/?l=linux-block&m=150695879309606. See also Luis' cover letter "[RFC 0/5] fs: replace kthread freezing with filesystem freeze/thaw" (https://marc.info/?l=linux-block&m=150705690302420). > 2) RCU read lock is missed in fast path Did you really post this as a review comment on my patch series? Anyway, this is easy to address. > 3) bad patch title: > > - such as : 'scsi-mq: Reduce suspend latency' > this is very misleading since it is actually bug fix > > - such as : "Make SCSI device suspend and resume work reliably" > also a bit not accurate Same here - had you posted this as a review comment before? Anyway, this is also easy to address. > Also holding sdev->state_mutex before freezing queue might > cause deadlock since this lock can be acquired in eh handler( > scsi_eh_offline_sdevs()) Had you posted this as a comment before? Anyway, I will address this comment too. Bart.
