> On 21 Sep 2017, at 13.26, Rakesh Pandit <rakesh@xxxxxxxxxx> wrote: > > It seems pblk_dealloc_page would race against pblk_alloc_pages for > line bitmap for sector allocation. The chances are very low but might > as well protect the bitmap properly. It's not even in fast path. > > Signed-off-by: Rakesh Pandit <rakesh@xxxxxxxxxx> > --- > drivers/lightnvm/pblk-core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c > index a230125..b92eabc 100644 > --- a/drivers/lightnvm/pblk-core.c > +++ b/drivers/lightnvm/pblk-core.c > @@ -502,12 +502,14 @@ void pblk_dealloc_page(struct pblk *pblk, struct pblk_line *line, int nr_secs) > u64 addr; > int i; > > + spin_lock(&line->lock); > addr = find_next_zero_bit(line->map_bitmap, > pblk->lm.sec_per_line, line->cur_sec); > line->cur_sec = addr - nr_secs; > > for (i = 0; i < nr_secs; i++, line->cur_sec--) > WARN_ON(!test_and_clear_bit(line->cur_sec, line->map_bitmap)); > + spin_lock(&line->lock); Changed this to spin_unlock() when picking it up. Javier.
Attachment:
signature.asc
Description: Message signed with OpenPGP
