Christoph Hellwig <hch@xxxxxx> writes: [...] > @@ -965,7 +932,8 @@ void bsg_unregister_queue(struct request_queue *q) > EXPORT_SYMBOL_GPL(bsg_unregister_queue); > > int bsg_register_queue(struct request_queue *q, struct device *parent, > - const char *name, void (*release)(struct device *)) > + const char *name, const struct bsg_ops *ops, > + void (*release)(struct device *)) Wouldn't it make sense to put the ->release() method into bsg_ops as well? The current prototype of bsg_register_queue isn't exactly what I would call a sane API. -- Johannes Thumshirn Storage jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
