On Mon, Oct 02, 2017 at 03:42:44PM +0200, Christoph Hellwig wrote: > This looks ok to me, or at least better than the version from Ming to > archive the same. I kinda hate to add more REQ_* flags than > really nessecary though. Maybe instead of the mapping to REQ_* as > suggested to ming blk_queue_enter should instead take the BLK_MQ_REQ_* > flags and we'll add BLK_MQ_REQ_PREEMPT, and pass those to > blk_get_request. If it wasn't for Linus beeing angry due to block > churn I'd be very tempted to suggest that. Actually, based on the next patch in the series from Ming we could add a blk_get_request_flags() or similar that takes the BLK_MQ_REQ_* flags, which would be my preferred method.
