Re: [PATCH] bcache: fix a comments typo in bch_alloc_sectors()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: 10074136 <tang.junhui@xxxxxxxxxx>

> Code comments in alloc.c:bch_alloc_sectors() mentions a function
> name find_data_bucket(), the correct function name should be
> pick_data_bucket() indeed. bch_alloc_sectors() is a quite important
> function in bcache allocation code, fixing the typo may help
> other people to have less confusion.
> 
> Signed-off-by: Coly Li <colyli@xxxxxxx>
> ---
>  drivers/md/bcache/alloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/md/bcache/alloc.c b/drivers/md/bcache/alloc.c
> index cacbe2dbd5c3..071ff28be912 100644
> --- a/drivers/md/bcache/alloc.c
> +++ b/drivers/md/bcache/alloc.c
> @@ -600,7 +600,7 @@ bool bch_alloc_sectors(struct cache_set *c, struct bkey *k, unsigned sectors,
>  
>  		 /*
>  		  * If we had to allocate, we might race and not need to allocate the
> -		  * second time we call find_data_bucket(). If we allocated a bucket but
> +		  * second time we call pick_data_bucket(). If we allocated a bucket but
>  		  * didn't use it, drop the refcount bch_bucket_alloc_set() took:
>  		  */
>  		 if (KEY_PTRS(&alloc.key))

Yes, It's useful for code reading, Thanks.

Reviewed-by: Tang Junhui <tang.junhui@xxxxxxxxxx>



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux