Re: [PATCH V5 07/14] scsi: sd_zbc: Initialize device request queue zoned data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2017-09-25 at 15:14 +0900, Damien Le Moal wrote:
> +	return kzalloc_node(BITS_TO_LONGS(sdkp->nr_zones)
> +			    * sizeof(unsigned long),

Does this perhaps fit on one line?

> +/**
> + * sd_zbc_get_seq_zones - Parse report zones reply to identify sequential zones
> + * @sdkp: disk used
> + * @buf: report reply buffer
> + * @seq_zone_bitamp: bitmap of sequential zones to set
> + * @zno: Zone number of the first zone in the report

'zno' is an input and output parameter but the above line only describes what
happens with the value passed to sd_zbc_get_seq_zones(). I think we also need a
description for the value of 'zno' upon return.

> + * Parse reported zone descriptors to find sequiential zones.
                                              ^^^^^^^^^^^
                                              sequential?

Otherwise this patch looks fine to me.

Bart.




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux