On 9/24/17 17:18, Christoph Hellwig wrote: >> + if (q->seq_zones && test_bit(zno, q->seq_zones)) >> + return BLKPREP_OK; > > Isn't the check above inverted? Also shouldn't it use blk_rq_zone_is_seq? > E.g. > > if (!blk_rq_zone_is_seq(cmd->request)) > return BLKPREP_OK; > ? Arrg ! Good catch. I tested only the scsi-mq case which does not use this path anymore (same test used, but at the scheduler level). Silly of me. I should have properly tested all cases. Will fix this. Thanks. -- Damien Le Moal Western Digital Research