On Thu, Sep 21, 2017 at 04:37:48PM +0200, Christoph Hellwig wrote: > On Thu, Sep 21, 2017 at 07:22:17AM +0200, Johannes Thumshirn wrote: > > > But head also has connotations in the SAN world. Maybe nvme_ns_chain? > > > > I know that's why I didn't really like it all too much in the first place as > > well. For nvme_ns_chain, it's not a chain really (the list itself is a chain, > > the structure really is the list head...), but I suck at naming things so. > > Well, it _is_ the structure for the namespace, and that's the fundamental > problem here given that we use that name for something else at the > moment. > > We could hav nvme_namespace and nvme_ns, but I'm not sure that this > helps clarity.. If there weren't resistence to renaming structs, it would be more aligned to how the specification calls these if we rename nvme_ns to nvme_ns_path, and what you're calling nvme_ns_head is should just be the nvme_ns.
