On 09/18/2017 12:56 PM, Matias Bjørling wrote:
Den 18. sep. 2017 09.56 skrev "Javier González" <jg@xxxxxxxxxxx <mailto:jg@xxxxxxxxxxx>>:> On 17 Sep 2017, at 23.04, Rakesh Pandit <rakesh@xxxxxxxxxx <mailto:rakesh@xxxxxxxxxx>> wrote: > > Remove repeated calculation for number of channels while creating a > target device. > > Signed-off-by: Rakesh Pandit <rakesh@xxxxxxxxxx <mailto:rakesh@xxxxxxxxxx>> > --- > > This is also a trivial change I found while investigating/working on > other issue. > > drivers/lightnvm/core.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c > index 1b8338d..01536b8 100644 > --- a/drivers/lightnvm/core.c > +++ b/drivers/lightnvm/core.c > @@ -139,7 +139,6 @@ static struct nvm_tgt_dev *nvm_create_tgt_dev(struct nvm_dev *dev, > int prev_nr_luns; > int i, j; > > - nr_chnls = nr_luns / dev->geo.luns_per_chnl; > nr_chnls = (nr_chnls_mod == 0) ? nr_chnls : nr_chnls + 1; > > dev_map = kmalloc(sizeof(struct nvm_dev_map), GFP_KERNEL); > -- > 2.7.4 We wanted to make sure that nr_chnls was really, really set :) Reviewed-by: Javier González <javier@xxxxxxxxxxxx <mailto:javier@xxxxxxxxxxxx>> What the hell... must have been a patch or merge that went wrong.
Thanks Rakesh. I pulled it in for 4.15.
