On Wed, Sep 20, 2017 at 06:58:22PM -0400, Keith Busch wrote: > > + sprintf(head->disk->disk_name, "nvme/ns%d", head->instance); > > Naming it 'nvme/ns<#>', kobject_set_name_vargs is going to change that > '/' into a '!', so the sysfs entry is named 'nvme!ns<#>'. Not a big > deal I suppose, but I just thought it looked odd since '!' has special > meaning in shells. I noticed the odd renaming in sysfs and though about gettind rid of the /dev/nvme/ directory. I just need to come up with a good name for the device nodes - the name can't contain /dev/nvme* as nvme-cli would break if it sees files that start with nvme in /dev/. /dev/nvmN ?