On 09/18/2017 07:47 PM, Christoph Hellwig wrote: > Don't rename it to a way to long name. Either add a separate mutex > for your purpose (unless there is interaction between freezing and > blktrace, which I doubt), or properly comment the usage. I would agree with you if the long name causes the expressions hard to read. In this particular case, it is just the single parameter to the mutex_lock() and mutex_unlock() functions. There is no confusion and overly long lines. So I think it is OK. In fact, I got the opposite advices in the past that some people prefer long descriptive names than short and cryptic names. Cheers, Longman
