On Fri, Sep 15, 2017 at 08:07:01PM +0200, Christoph Hellwig wrote: > Hi Anish, > > I looked over the code a bit, and I'm rather confused by the newly > added commands. Which controller supports them? Also the NVMe > working group went down a very different way with the ALUA approch, > which uses different grouping concepts and doesn't require path > activations - for Linux we'd really like to stick to only standardized > multipath implementations. Hi Christoph, Thanks for looking over the code. The newly added commands were to support Asymmetric NVME Namespace Subsystem. Though, I can remove those commands and make it active-active configuration. I noticed you have sent out the review with changes adding new structures and functions which makes it very similar in terms of implementation. The only reason I proposed given changes, as it doesn't require any change to kernel.