On 9/16/17 02:45, Christoph Hellwig wrote: > On Fri, Sep 15, 2017 at 07:06:34PM +0900, Damien Le Moal wrote: >> __blk_mq_debugfs_rq_show() and blk_mq_debugfs_rq_show() are exported >> symbols but ar eonly declared in the block internal file >> block/blk-mq-debugfs.h. which is not cleanly accessible to files outside >> of the block directory. >> Move the declaration of these functions to the new file >> include/linux/blk-mq-debugfs.h file to make the declarations cleanly >> available to other modules. >> >> While at it, also move the definition of the blk_mq_debugfs_attr >> structure to allow scheduler modules outside of the block directory to >> define debugfs attributes. > > I think we should keep them local to block/ where all I/O schedulers > live, so: NAK. OK. I will drop this one and 02/12. Thanks. -- Damien Le Moal Western Digital Research
