On 01/09/17 16:28, Adrian Hunter wrote: > On 01/09/17 15:58, Ulf Hansson wrote: >> + Christoph >> >> On 1 September 2017 at 13:42, Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote: >>> On 31/08/17 14:56, Adrian Hunter wrote: >>>> Here is V7 of the hardware command queue patches without the software >>>> command queue patches, now using blk-mq. >>>> >>>> HW CMDQ offers 25% - 50% better random multi-threaded I/O. I see a slight >>>> 2% drop in sequential read speed but no change to sequential write. >>> >>> Any comments? >> >> A couple of overall comments, for now. >> >> To make sure we don't overlook something when converting to mq, I >> would prefer that we first convert the existing mmc block code to mq, >> then we add CMDQ on top. > > That doesn't make sense. This patch set is not converting the legacy driver > to mq therefore it cannot overlook anything for converting to mq. And then you go silent again. I can send blk-mq support for legacy requests in a few days if you like, but I want to hear a better explanation of why you are delaying CQE support.