On Fri, 2017-09-01 at 20:36 +0900, Damien Le Moal wrote: > +/* Zone types of REPORT ZONES zone descriptors */ > +enum zbc_zone_type { > + ZBC_ZONE_TYPE_CONV = 0x1, > + ZBC_ZONE_TYPE_SEQWRITE_REQ = 0x2, > + ZBC_ZONE_TYPE_SEQWRITE_PREF = 0x3, > + /* 0x4 to 0xf are reserved */ > + ZBC_ZONE_TYPE_RESERVED = 0x4, > +}; Hello Damien, Since no code is using ZBC_ZONE_TYPE_RESERVED, is the comment about reserved values sufficient and can the definition of ZBC_ZONE_TYPE_RESERVED be left out? Anyway: Reviewed-by: Bart Van Assche <bart.vanassche@xxxxxxx>