On Thu, Aug 24, 2017 at 10:45:56AM +0200, Christoph Hellwig wrote:
> > /**
> > - * bsg_destroy_job - routine to teardown/delete a bsg job
> > + * bsg_teardown_job - routine to teardown a bsg job
> > * @job: bsg_job that is to be torn down
> > */
> > -static void bsg_destroy_job(struct kref *kref)
> > +static void bsg_teardown_job(struct kref *kref)
>
> Why this rename? The destroy name seems to be one of the most
> common patterns for the kref_put callbacks.
>
Hmm, I did it mostly so it is symmetric with bsg_prepare_job() and it
doesn't really itself destroy the job-struct anymore. If there are other
thing amiss I can change that along with them, if it bothers poeple.
Beste Grüße / Best regards,
- Benjamin Block
>
> Otherwise this looks fine:
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
>
--
Linux on z Systems Development / IBM Systems & Technology Group
IBM Deutschland Research & Development GmbH
Vorsitz. AufsR.: Martina Koederitz / Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen / Registergericht: AmtsG Stuttgart, HRB 243294
