Looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx> Although as a follow on I would also move the debug printks from skd_end_request to skd_softirq_done, then remove skd_end_request and rename skd_softirq_done to skd_complete_rq to fit what other drivers are doing a little more closely.