On 08/09/2017 04:10 PM, Christoph Hellwig wrote: > On Mon, Aug 07, 2017 at 08:09:11AM +0200, Hannes Reinecke wrote: >> On 08/05/2017 01:39 PM, Christoph Hellwig wrote: >>> Can you use normal linux style for the code instead of copy and >>> pasting the weird naming and capitalization from the DAC960 driver? >>> >> Yes; already planned for v2. But first wanted to get some general >> feedback (like: is anyone interested in that at all?) > > Yes, please go ahead and kill off the DAC960 driver. > I knew you would be saying that :-) >> >>> Also please use the driver name as prefix for the functions. >>> >> Ok. >> >>> Maybe myraid instead of mylex? >>> >> Nah; I'd rather stick with mylex. >> (Especially as it says 'Mylex' in big fat letters on the board :-) > > Naming drivers after the vendor only is usually a bad idea as vendors > have/had multiple products. In this case we have plenty other drivers > that support Mylex products. > Okay. Make it 'myraid_pio' and 'myraid_mmio' then. Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
