On Tue, Jul 18, 2017 at 08:40:18AM +0100, Roger Pau Monné wrote: > On Tue, Jul 18, 2017 at 08:53:28AM +0800, Ming Lei wrote: > > On Mon, Jul 17, 2017 at 05:02:27PM +0100, Roger Pau Monné wrote: > > > On Mon, Jul 17, 2017 at 11:06:28PM +0800, Ming Lei wrote: > > > > On Mon, Jul 17, 2017 at 12:20:56PM +0100, Roger Pau Monné wrote: > > > > > seems fairly easy to mess up and call "start" on a "quiesced" queue > > > > > (or the other way around). > > > > > > > > Definitely it shouldn't be worried because start/stop is removed > > > > in this patchset. > > > > > > Hm, how is that? I haven't seen any patch to blkfront to remove the > > > usage of start/stop, am I missing something? > > > > http://secure-web.cisco.com/19iIG2bc3Ce2_t8mSF4YQ2LopepIvjAOqnPAXQ_QahSNOEvLBmechzNZ0pQOPfSRhy3hyC4t6L-JJzu81FvWRyLoBmhtq7F9uEk7XZsTt-XNxLN1KdEJvEeUAWelYSd9NthbvpGad6DmpJ0QCHSOgq4mRcDaqlz5mRmNkTvxls-ri1qCqy6am0jTDdraGINb_BUyV0894BtaFOMGJGEKLjcrBfFfT6C5XHSEdsiuB12ZLIUyaRVyU0TCUz6Sm4uhD/http%3A%2F%2Fmarc.info%2F%3Fl%3Dlinux-block%26m%3D150007418321196%26w%3D2 > > Sadly I have not been CCed or otherwise I've lost patch #5. Related to > that patch AFAICT kick_pending_request_queues can be removed, since > it's only used by one caller (or it can even be removed in this patch, > #1). There are two callers: blkfront_connect() and blkif_restart_queue(). -- Ming
