On Fri, 30 Jun 2017, bcache@xxxxxxxxxxxxxxxxxx wrote: > From: Tang Junhui <tang.junhui@xxxxxxxxxx> > > set_gc_sectors() has been called in bch_gc_thread(), and it was called > again in bch_btree_gc_finish() . The following call is unnecessary, so > delete it. I'm trying to follow the call path that proves that this is safe, but I'm not seeing it. Can you explain this in more detail? -- Eric Wheeler > > Signed-off-by: Tang Junhui <tang.junhui@xxxxxxxxxx> > --- > drivers/md/bcache/btree.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c > index 77aa20b..66d8036 100644 > --- a/drivers/md/bcache/btree.c > +++ b/drivers/md/bcache/btree.c > @@ -1662,7 +1662,6 @@ static size_t bch_btree_gc_finish(struct cache_set *c) > > mutex_lock(&c->bucket_lock); > > - set_gc_sectors(c); > c->gc_mark_valid = 1; > c->need_gc = 0; > > -- > 1.8.3.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-bcache" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html >
