On 07/10/2017 12:40 PM, Shaohua Li wrote: > bio_free isn't a good place to free cgroup info. There are a > lot of cases bio is allocated in special way (for example, in stack) and > never gets called by bio_put hence bio_free, we are leaking memory. This > patch moves the free to bio endio, which should be called anyway. The > bio_uninit call in bio_free is kept, in case the bio never gets called > bio endio. > > This assumes ->bi_end_io() doesn't access cgroup info, which seems true > in my audit. > > This along with Christoph's integrity patch should fix the memory leak > issue. Applied, thanks Shaohua. -- Jens Axboe
