mutex_destroy does nothing normally (may not be true in the future), but when debug mutex is turned on it helps with debugging - mutex_destroy in mutex-debug.c. It's not about freeing of the memory. It's more about consistency of the use of mutex and making the code future proof. Thanks, Linag On Thu, Jul 6, 2017 at 2:27 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Fri, Jun 30, 2017 at 01:42:55PM -0700, bcache@xxxxxxxxxxxxxxxxxx wrote: >> From: Liang Chen <liangchen.linux@xxxxxxxxx> >> >> mutex_destroy does nothing most of time, but it's better to call >> it to make the code future proof and it also has some meaning >> for like mutex debug. > > It shouldn't really - we should get the destroy behavior for free > when doing a slab free of the area. > > What issue are you trying to solve?