On Thu, Jul 06, 2017 at 01:06:21AM +0200, Christoph Hellwig wrote: > I wonder if we should simply always kick the list and remove the > parameter and blk_mq_kick_requeue_list. It seems like this split > has caused a lot more harm then good, and the other drivers using > it that way are probably having issues as well. It is only NVMe and DM which use blk_mq_kick_requeue_list() in this way, other drivers passes either ture or false to blk_mq_kick_requeue_list(). Yeah, looks DM need to switch to this way too. Drivers may want to schedule at batch especially in fast path, so maybe they should be allowed to use in splitting way. -- Ming
