Re: [PATCH blktests 2/2] block/011: Perform PCI reset while doing IO

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 26, 2017 at 02:27:24PM -0700, Omar Sandoval wrote:
[...]
> > +
> > +	while kill -0 $! 2>/dev/null; do
> > +		echo 0 > "/sys/bus/pci/devices/${pdev}/enable"
> > +		sleep .2
> > +		echo 1 > "/sys/bus/pci/devices/${pdev}/enable"
> 
> Test looks good, but one question: do you want another sleep .2 here?
> Like this, you immediately disable it after enabling it, but maybe
> that's what you want :)

Good catch. I'll fix it up.

-- 
Johannes Thumshirn                                          Storage
jthumshirn@xxxxxxx                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux