On 06/26/2017 03:29 PM, Omar Sandoval wrote: > On Mon, Jun 26, 2017 at 08:25:36AM -0600, Jens Axboe wrote: >> On 06/26/2017 08:06 AM, Johannes Thumshirn wrote: >>> On Fri, Jun 23, 2017 at 09:36:14AM -0600, Jens Axboe wrote: >>>> On 06/23/2017 08:29 AM, Johannes Thumshirn wrote: >>>>> From: Omar Sandoval <osandov@xxxxxx> >>>>> >>>>> This test-case performs I/O with fio while doing PCI disable/enable >>>>> cycles. >>>>> >>>>> In the results we don't care for I/O errors but for hiccups in dmesg only. >>>> >>>> Let's get this in, that would be a very useful test. A few comments - >>>> not necessarily on this patch in particular, but for future cleanups >>>> and improvements. >>>> >>>>> + if _test_dev_is_rotational; then >>>>> + size="32m" >>>>> + else >>>>> + size="1g" >>>>> + fi >>>> >>>> I introduced this idea in one of my previous patches. I wonder if we >>>> should turn that into a helper. Pass in the dev, get returned a >>>> suitable fio size, instead of hard coding this in each job that >>>> needs it. > > What I wanted to have here eventually is a helper that you can run when > you just want arbitrary I/O. Haven't gotten around to it. That would be handy. Until that happens, I would not worry about it, it's not like it's a lot of work to just copy/paste the "do random reads QD=x with Y jobs" between jobs. It'd be fine as a separate cleanup at some point. -- Jens Axboe
