On 06/20/2017 08:15 PM, Bart Van Assche wrote: > From: Bart Van Assche <bart.vanassche@xxxxxxxxxxx> > > Initialization of blk-mq requests is a bit weird: blk_mq_rq_ctx_init() > is called after a value has been assigned to .rq_flags and .rq_flags > is initialized in __blk_mq_finish_request(). Initialize .rq_flags in > blk_mq_rq_ctx_init() instead of relying on __blk_mq_finish_request(). > Moving the initialization of .rq_flags is fine because all changes > and tests of .rq_flags occur between blk_get_request() and finishing > a request. > > Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx> > Cc: Christoph Hellwig <hch@xxxxxx> > Cc: Hannes Reinecke <hare@xxxxxxxx> > Cc: Omar Sandoval <osandov@xxxxxx> > Cc: Ming Lei <ming.lei@xxxxxxxxxx> > --- > block/blk-mq.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Reviewed-by: Hannes Reinecke <hare@xxxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)